sync: Once is no longer unsafe, update docs #14813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,11 +29,9 @@ use mutex::{StaticMutex, MUTEX_INIT}; | |||
| /// use sync::one::{Once, ONCE_INIT}; | |||
| /// | |||
| /// static mut START: Once = ONCE_INIT; | |||
There was a problem hiding this comment.
Nope. Can't borrow static which contains Unsafe.
bors
added a commit
that referenced
this pull request
Jun 12, 2014
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Fixes exit/yield points not getting highlighted in such blocks for `highlight_related` (rust-lang#14813; and possibly other bugs in features that use `preorder_expr`).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…=Veykril Fix `preorder_expr` skipping the `else` block of let-else statements Fixes exit/yield points not getting highlighted in such blocks for `highlight_related` (rust-lang#14813; and possibly other bugs in features that use `preorder_expr`).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 13, 2025
Looks for `TryFrom` implementations with uninhabited error types and suggests to implement `From` instead. Fixes rust-lang/rust-clippy#2144 --- changelog: Add [`infallible_try_from`] lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.